You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes a bug where $currentPlan.deploymentSize could be undefined even when $currentPlan itself was truthy, causing the file-size limit to incorrectly default to 0 bytes for cloud users. It also replaces hardcoded 'File size exceeds 10MB' error messages with a dynamic value derived from readableMaxSize, and restructures the paused-project modal footer to render an explicit mobile layout.
Four deployment-upload files (create-function, createManual, create-site, createManualDeploymentModal) each gain the ?.deploymentSize optional-chaining guard and a dynamic error message built from humanFileSize.
pausedProjectModal splits its footer into explicit {#if $isSmallViewport} / {:else} branches so buttons render full-width and stacked on mobile, preserving the existing behaviour where the Upgrade button is only shown on larger viewports.
Confidence Score: 5/5
Safe to merge — changes are narrowly scoped to fixing a falsy-deploymentSize guard, improving error messages, and improving mobile layout.
The optional-chaining fix is correct and targets a real edge case where a cloud plan object can exist without a deploymentSize field. The dynamic error message follows the existing readableMaxSize.value + readableMaxSize.unit pattern used throughout the codebase. The responsive layout refactor in pausedProjectModal preserves the pre-existing behaviour for the Upgrade button on mobile. No logic regressions were identified across the five changed files.
Adds ?.deploymentSize optional chaining so a plan without a deploymentSize field correctly falls back to the regional limit; replaces hardcoded "10MB" error message with the dynamic readable size.
Applies the ?.deploymentSize optional-chaining fix and removes the stale "already in MB" comment; error message was already dynamic so no message change here.
Restructures footer buttons to use a proper two-branch layout for small vs. large viewports; Upgrade button behaviour on mobile is unchanged from before (it was already hidden via {#if !$isSmallViewport}).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)