Fix deployment upload archive validation and queue state#3021
Fix deployment upload archive validation and queue state#3021HarshMN2345 merged 2 commits intomainfrom
Conversation
Greptile Summary
Confidence Score: 4/5Safe to merge with one minor UX regression in the site-creation page's invalid-file error messaging. Only P2 findings remain. The core logic (progress tracking, queue identity, archive validation) is correctly implemented. The single regression (wrong toast message for Dropzone-native rejected files) is a non-critical UX issue. src/routes/(console)/project-[region]-[project]/sites/create-site/manual/+page.svelte — handleInvalid fallback path. Important Files Changed
Reviews (2): Last reviewed commit: "fix: restore deployment upload progress" | Re-trigger Greptile |
| </Typography.Text> | ||
| <Upload.Dropzone | ||
| extensions={['gz', 'tar']} | ||
| extensions={['gz']} |
There was a problem hiding this comment.
Can you try to upload something like .png.gz? If that will work, I think thats wrong. Curious if tere is any way to be more specific. If not by inpu itself, maybe by JS implementation
There was a problem hiding this comment.
Upload.Dropzone only supports filtering by extension, so ['gz'] is the closest we can get there. That still allows files like .png.gz, so I added a check in JS (file.name.endsWith('.tar.gz')) after selection to make sure only .tar.gz files are accepted.
What does this PR do?
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)