Skip to content

feat:add SSR start command support for sites#2990

Merged
HarshMN2345 merged 10 commits intomainfrom
fix-ssr-start-command-sites
May 4, 2026
Merged

feat:add SSR start command support for sites#2990
HarshMN2345 merged 10 commits intomainfrom
fix-ssr-start-command-sites

Conversation

@HarshMN2345
Copy link
Copy Markdown
Member

What does this PR do?

image

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 22, 2026

Greptile Summary

This PR wires startCommand (the SSR start command) end-to-end: a shared type in sites.ts, the uploader, all sites.create/sites.update call-sites, and the UI fields in every creation and settings flow. The previous review's concerns about the field being shown unconditionally (deploy/+page.svelte), the empty-string passthrough (repository/+page.svelte), and the missing uploadSiteDeployment argument (manual/+page.svelte) have all been addressed in this revision. The only remaining note is a Svelte 5 anti-pattern in the merged $effect in updateBuildSettings.svelte where lastFrameworkAdapterKey is both read (as a tracked dependency) and written in the same effect, causing a no-op double-run and a development console warning.

Confidence Score: 4/5

Safe to merge; previously flagged P1 issues are addressed and the one remaining note is a cosmetic Svelte 5 anti-pattern.

All P1 findings from prior review rounds (unconditional field render, empty-string API passthrough, missing uploader argument) are resolved. The single open note is a P2 Svelte 5 double-run pattern that does not affect correctness.

src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte — lastFrameworkAdapterKey read/write in the same $effect.

Important Files Changed

Filename Overview
src/lib/stores/sites.ts Adds shared FrameworkAdapterWithStartCommand type extending Models.FrameworkAdapter, resolving the duplicate local type previously scattered across five files.
src/lib/stores/uploader.ts Threads startCommand through uploadSiteDeployment, extracts deploymentPayload for clarity; no logic changes beyond the new field.
src/routes/(console)/project-[region]-[project]/sites/create-site/configuration.svelte Adds startCommand prop, SSR-guarded input field, and adapterDefaultsKey debounce guard; ?? '' consistency applied to Reset disabled checks.
src/routes/(console)/project-[region]-[project]/sites/create-site/deploy/+page.svelte Adds shouldShowStartCommand derived from adapters[0], guards Start Command field and API call behind SSR check, reads ?start URL param.
src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte Merges two $effects into one with frameworkAdapterKey guard; adds startCommand state, SSR-guarded UI, and isUntouched tracking; changes selectedFramework from $derived to $state to enable user-editable selection.
src/routes/(console)/project-[region]-[project]/sites/create-site/repositories/repository-[repository]/+page.svelte Adds startCommand and normalises all four commands to `
src/routes/(console)/project-[region]-[project]/sites/create-site/manual/+page.svelte Passes startCommand to both sites.create and uploader.uploadSiteDeployment, and binds it through to the Configuration component.
src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/createGitDeploymentModal.svelte Passes `site.startCommand
src/routes/(public)/sites/deploy/+page.svelte Forwards ?start URL parameter to the create-site deploy flow, consistent with install, build, and output params.

Reviews (9): Last reviewed commit: "fix sites repository create command norm..." | Re-trigger Greptile

@HarshMN2345 HarshMN2345 requested a review from Meldiron April 22, 2026 10:28
@HarshMN2345 HarshMN2345 merged commit 777ccd3 into main May 4, 2026
4 checks passed
@HarshMN2345 HarshMN2345 deleted the fix-ssr-start-command-sites branch May 4, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants