You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 3, 2021. It is now read-only.
I really don't want to maintain a typescript definition. Moreover it shouldn't matter, as one place may instantiate it knowing it is a RobustWebSocket but all other consumers treat it as a normal WebSocket instance and do not know the difference. That is also why the static constants were not put on RobustWebSocket. Not interested in taking this PR.
That's fine to skip the Typescript definition. But the standard web socket has constants in the prototype. That means anyone can access the constants in both WebSocket.CLOSED and (new WebSocket()).CLOSED. Please check here.
In order to make it fully transparent, it is necessary to add the constants.
hktonylee
changed the title
Added TypeScript type definition, and make it fully complies to standard web socket
Added constants to fully comply to standard websocket
Aug 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.