Conversation
KMilej
force-pushed
the
refactor/nodejs-quickstart
branch
from
ef50f88 to
3c2999d
Compare
- ApproovApplication.js: added centralized error handling (HttpError + handleRequestError) and return 400 for invalid request URL. - approovTokenVerifier now passes auth failures to middleware flow (next(error)) for missing Approov-Token, invalid token, and binding mismatch. - Token binding now uses constructTokenBindingInput(req, bindingHeaders) and generateTokenBindingHash(), with explicit 401 missing_binding_header when a required header is absent. - scripts/build.sh now validates APPROOV_BASE64URL_SECRET in .env (rejects empty/placeholder values) before starting Docker. - scripts/build.sh now prints container logs on startup failure; runtime moved to Node 24 (package engines + Docker base image), and .dockerignore + LICENSE were added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/token-check,/token-binding,/token-double-binding) and unprotected endpoints..envconfiguration, and a CLI test harness.How to run
cp .env.example .env.APPROOV_BASE64URL_SECRET.bash run_server.sh.bash test.sh.