make AsyncRemoveDuplicatesSequence's init public#291
Closed
yermukhanbet wants to merge 1 commit intoapple:mainfrom
Closed
make AsyncRemoveDuplicatesSequence's init public#291yermukhanbet wants to merge 1 commit intoapple:mainfrom
yermukhanbet wants to merge 1 commit intoapple:mainfrom
Conversation
Member
|
Right now this is intentional. We might want to revisit this on a larger scale if we do it and make all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our team is using removeDuplicates() function for the AsyncPublisher in one of our service protocols as a return type. Since for each service we have both live and mock structs, I faced an issue with mocking ASyncRemoveDuplicatesSequence value, as the init is internal.
In this PR I changed it to public. Please, let me know if internal init was intentional approach, so I will try to find another possible way for mocking the return type.