feat: setup trading partner (trade magma) [AMB-2421]#697
Open
feat: setup trading partner (trade magma) [AMB-2421]#697
Conversation
- Remove magma.schema.graphql (712-line Magma API schema dump, not imported anywhere — noise in the PR diff) - Remove unused AmbossService injection from MagmaResolver and AmbossModule from MagmaModule - Extract inline BigInt order-size calculation into computeMagmaOrderSize() helper with a clear doc comment explaining PURCHASE vs SALE semantics - Drop unused `asset` and `pagination` fields from getOffersQuery - Fix clearSelection in TradingOffers to check assetId ownership in addition to groupKey when switching to Sell mode
Cover the four channel setup scenarios: - No channels: full setup (Magma inbound + outbound) for PURCHASE and SALE - Outbound exists: skip outbound, Magma only (skipOutboundChannel flag) - SALE with grouped asset: passes groupKey instead of assetId to fundAssetChannel - Peer connection: socket lookup from graph when none provided - Error cases: Magma failure, payment failure, validation
wthrajat
reviewed
Apr 9, 2026
wthrajat
reviewed
Apr 9, 2026
wthrajat
reviewed
Apr 9, 2026
wthrajat
reviewed
Apr 9, 2026
wthrajat
reviewed
Apr 9, 2026
wthrajat
reviewed
Apr 9, 2026
jcbrand
reviewed
Apr 10, 2026
jcbrand
reviewed
Apr 10, 2026
jcbrand
reviewed
Apr 10, 2026
jcbrand
reviewed
Apr 10, 2026
wthrajat
reviewed
Apr 10, 2026
wthrajat
reviewed
Apr 10, 2026
wthrajat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.