fix: adding offset clamp#33
Open
usanvict wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_clamp_offsetto_ApifyGenericToolthat floors theoffsetparameter to0, preventing invalid negative values from being sent to the Apify APIApifyGetDatasetItemsTool._runwhereoffsetwas previously passed through uncheckedMotivation
The
limitparameter inApifyGetDatasetItemsToolwas already clamped via_clamp_items, but theoffsetparameter was passed directly to the API without validation. Per the Apify Get Dataset Items API,offsetis a non-negative number (default0) representing the number of items to skip. Negative values are invalid and could cause unexpected API behavior. It is especially necessary to minimise inappropriate token usage.Changes
langchain_apify/tools.py— Added_clamp_offsetstatic method to_ApifyGenericToolthat ensuresoffset >= 0. Applied it inApifyGetDatasetItemsTool._run.tests/unit_tests/test_tools.py— Addedtest_clamp_offset_floor_is_zerocovering three cases: negative offset is clamped to 0, zero passes through, and positive values pass through unchanged.