test: Bump apify-cli subprocess timeouts to 600s for heavier templates#1910
Closed
vdusek wants to merge 1 commit into
Closed
test: Bump apify-cli subprocess timeouts to 600s for heavier templates#1910vdusek wants to merge 1 commit into
vdusek wants to merge 1 commit into
Conversation
`apify push` waits server-side for the actor's Docker build to complete before returning, and the heavier templates (e.g. adaptive-parsel with a ~550 MB base image) consistently exceed the previous 120s budget — all 4 rerun attempts hit the timeout, so retries don't help. Bump every apify-cli subprocess timeout to 600s; the 1800s pytest-timeout still bounds a truly hung CLI.
vdusek
added
t-tooling
github-actions
Bot
added
the
tested
Collaborator
Author
|
Folding into #1909 — same scheduled e2e failure mode (Apify builds need more time). Branch will be deleted. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1910 +/- ##
==========================================
- Coverage 92.89% 92.87% -0.03%
==========================================
Files 167 167
Lines 11714 11714
==========================================
- Hits 10882 10879 -3
- Misses 832 835 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
poetry-curl-impersonate-adaptive-parselvariant oftest_static_crawler_actor_at_apifyis failing every scheduled run withsubprocess.TimeoutExpired: Command '['apify', 'push']' timed out after 120 seconds(example failing job). The job total (522s) matches 4 × 120s + setup, i.e. the timeout fires on every rerun — retries cannot absorb the wall.Root cause:
apify pushwaits server-side for the actor's Docker build to finish before returning. The captured stderr shows a ~550 MB base image mid-download when the timeout fires:So the CLI is not hung — the build is just genuinely slower than 120s for heavier templates (adaptive crawlers, playwright-based ones). The 120s timeout was added in #1905 with the reasoning that a hung CLI should fail fast, but that's a false dichotomy for builds that take 2–5 minutes.
Fix
Bump the timeout on all three apify-cli
subprocess.runcalls (login,init,push) from 120s to 600s. The 1800spytest-timeoutper test still bounds a truly hung CLI, and@pytest.mark.flaky(reruns=3)still covers transient network/CLI flakes.