Skip to content

test: Give Apify builds more time in scheduled e2e templates test #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 2 commits into from
May 22, 2026
+14 −5
Merged

test: Give Apify builds more time in scheduled e2e templates test #1909

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26e1c6e
test: Poll stagehand build client-side to avoid 60s server-side wait_…
vdusek May 22, 2026
2178830
test: Bump apify-cli subprocess timeouts to 600s for heavier templates
vdusek May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions tests/e2e/project_template/test_static_crawlers_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,14 +90,14 @@ async def test_static_crawler_actor_at_apify(
capture_output=True,
check=True,
cwd=tmp_path / actor_name,
timeout=120,
timeout=600,
)
subprocess.run( # noqa: ASYNC221, S603
['apify', 'init', '-y', actor_name], # noqa: S607
capture_output=True,
check=True,
cwd=tmp_path / actor_name,
timeout=120,
timeout=600,
)

build_process = subprocess.run( # noqa: ASYNC221
Expand All @@ -108,7 +108,7 @@ async def test_static_crawler_actor_at_apify(
# Prevent git from walking up into the surrounding project's .git/ when running under
# a basetemp inside the repo (see --basetemp in the e2e-templates-tests poe task).
env={**os.environ, 'GIT_CEILING_DIRECTORIES': str(tmp_path)},
timeout=120,
timeout=600,
)
# Get actor ID from build log
actor_id_regexp = re.compile(r'https:\/\/console\.apify\.com\/actors\/(.*)#\/builds\/\d*\.\d*\.\d*')
Expand All @@ -132,8 +132,17 @@ async def test_static_crawler_actor_at_apify(
if crawler_type == 'stagehand':
env_vars = actor.version('0.0').env_vars()
await env_vars.create(name='OPENAI_API_KEY', value=os.environ['OPENAI_API_KEY'], is_secret=True)
rebuild = await actor.build(version_number='0.0', wait_for_finish=600)
build_number = rebuild['buildNumber']
# `ActorClientAsync.build`'s `wait_for_finish` parameter is capped server-side at 60s,
# which is shorter than a stagehand build (playwright + browser deps). Trigger the build,
# then poll client-side via `BuildClientAsync.wait_for_finish` until it reaches a terminal
# status, and assert it succeeded before starting the run.
rebuild = await actor.build(version_number='0.0')
finished_build = await client.build(rebuild['id']).wait_for_finish(wait_secs=900)
assert finished_build is not None, 'Stagehand rebuild did not reach a terminal status within 900s.'
assert finished_build['status'] == 'SUCCEEDED', (
f'Stagehand rebuild did not succeed: status={finished_build["status"]!r}, build={finished_build}'
)
build_number = finished_build['buildNumber']

started_run_data = await actor.start(memory_mbytes=8192, build=build_number)
actor_run = client.run(started_run_data['id'])
Expand Down
Loading