-
Notifications
You must be signed in to change notification settings - Fork 62
chore: Use custom action to commit changes in CI instead of git commit
#609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
20d4098
9a72ef6
98c9fc8
7af2254
fd2ab9f
92d4f4e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -81,7 +81,7 @@ jobs: | |
| needs: [release_metadata, build_and_test] | ||
| runs-on: ubuntu-22.04 | ||
| outputs: | ||
| changelog_commitish: ${{ steps.commit.outputs.commit_long_sha || github.sha }} | ||
| changelog_commitish: ${{ steps.commit.outputs.commit_long_sha }} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will this be an issue in any of the other repositories? 🤔
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I fixed it everywhere already 🙂
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Very cool, thanks! |
||
| version_number: ${{ needs.release_metadata.outputs.version_number }} | ||
| tag_name: ${{ needs.release_metadata.outputs.tag_name }} | ||
| release_notes: ${{ needs.release_metadata.outputs.release_notes }} | ||
|
|
@@ -114,12 +114,11 @@ jobs: | |
|
|
||
| - name: Add changes to the release commit and push | ||
| id: commit | ||
| uses: EndBug/add-and-commit@v10 | ||
| uses: apify/actions/signed-commit@v1.1.2 | ||
| with: | ||
| author_name: Apify Release Bot | ||
| author_email: noreply@apify.com | ||
| message: 'chore(release): set package version to ${{ needs.release_metadata.outputs.version_number }} and update changelog [skip ci]' | ||
| pull: '--rebase --autostash' | ||
| github-token: ${{ secrets.APIFY_SERVICE_ACCOUNT_GITHUB_TOKEN }} | ||
|
|
||
| create_github_release: | ||
| name: Create github release | ||
|
|
@@ -145,7 +144,9 @@ jobs: | |
| - name: Checkout repository | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| ref: ${{ needs.update_changelog.outputs.changelog_commitish }} | ||
| # Always check out the default branch (not the SHA) so the commit | ||
| # action can push to a branch ref. | ||
| ref: ${{ github.event.repository.default_branch }} | ||
| token: ${{ secrets.APIFY_SERVICE_ACCOUNT_GITHUB_TOKEN }} | ||
|
|
||
| - name: Use Node.js 24 | ||
|
|
@@ -164,14 +165,11 @@ jobs: | |
| pnpm exec docusaurus api:version "$MAJOR_MINOR" | ||
|
|
||
| - name: Commit versioned docs | ||
| uses: EndBug/add-and-commit@v10 | ||
| uses: apify/actions/signed-commit@v1.1.2 | ||
| with: | ||
| author_name: Apify Release Bot | ||
| author_email: noreply@apify.com | ||
| message: 'docs: version docs for ${{ needs.update_changelog.outputs.version_number }} [skip ci]' | ||
| pull: '--rebase --autostash' | ||
| # `actions/checkout` detaches HEAD on SHA refs; EndBug needs a branch to push. | ||
| new_branch: ${{ github.event.repository.default_branch }} | ||
| github-token: ${{ secrets.APIFY_SERVICE_ACCOUNT_GITHUB_TOKEN }} | ||
|
|
||
| publish_to_npm: | ||
| name: Publish to npm | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, an oddball 🙂