chore: bundle v4 catch-up — config redesign + EventManager + StorageClient + ProxyConfiguration#597
Open
B4nan wants to merge 4 commits into
Open
chore: bundle v4 catch-up — config redesign + EventManager + StorageClient + ProxyConfiguration#597B4nan wants to merge 4 commits into
B4nan wants to merge 4 commits into
Conversation
B4nan
force-pushed
the
chore/v4-catchup-bundle
branch
7 times, most recently
from
856d554 to
5b6598a
Compare
B4nan
added a commit
to apify/crawlee
that referenced
this pull request
Apr 30, 2026
## Summary `packages/linkedom-crawler/src/internals/linkedom-crawler.ts` imports `cheerio` (`import * as cheerio from 'cheerio'`) but `@crawlee/linkedom`'s `package.json` doesn't list it as a dependency. It works inside the monorepo because cheerio is hoisted to the workspace root via other packages (`@crawlee/cheerio`, `@crawlee/utils`, `@crawlee/http`, …), so Node always finds it. **Downstream installs that depend only on `crawlee`** (which re-exports `@crawlee/linkedom`) **and don't pull any cheerio-using sibling** fail at runtime: ``` Error: Cannot find package 'cheerio' imported from .../node_modules/@crawlee/linkedom/internals/linkedom-crawler.js ``` This bit the apify-sdk-js v4 catch-up PRs (apify/apify-sdk-js#597) on a clean CI install — without this fix, every consumer has to ship a `cheerio` dev-dep workaround. The fix is one-line: declare `cheerio: "^1.0.0"` (matching what `@crawlee/cheerio` already pins).
B4nan
force-pushed
the
chore/v4-catchup-bundle
branch
3 times, most recently
from
d649a33 to
f0ced4f
Compare
B4nan
force-pushed
the
chore/v4-catchup-bundle
branch
9 times, most recently
from
24c1250 to
5908f2a
Compare
B4nan
force-pushed
the
chore/v4-catchup-bundle
branch
from
5908f2a to
b6057ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
A non-mergeable demo branch that bundles all four v4 catch-up PRs so reviewers can see green CI on the combined state.
PlatformEventManagerconstructor adaptStorageClientadapter +KeyValueStore.getPublicUrlasync URL signingProxyConfigurationv4 APIPinned at
crawlee@^4.0.0-beta.51.Recommended merge order: #583 → #594 → #595 → #596
The four focused PRs are rebased into a linear stack:
Each downstream branch already contains its predecessors as ancestors, so the merge order matters mostly for review/CI clarity:
Verified: a sequential merge of #583 → #594 → #595 → #596 into
origin/v4produces zero conflicts at each step. Locally the resulting state passes 75/75 active tests on Node 22 and Node 24. The tree is functionally equivalent to this bundle (sole diff is a stale ~69-linenode_modules/@crawlee/linkedom/node_modules/cheerioblock left in this bundle's lockfile from the cheerio-workaround era — pure regen artifact, not real divergence).Do not merge this PR
Merge the four focused PRs above instead. This branch will be deleted once they land.