feat: unified CLI telemetry event#1133
Merged
Merged
Conversation
github-actions
Bot
added
t-dx
patrikbraborec
force-pushed
the
fix/dual-command-telemetry-events
branch
from
64972d9 to
2662ac7
Compare
patrikbraborec
force-pushed
the
fix/dual-command-telemetry-events
branch
from
cdc7ae6 to
1a3a821
Compare
Contributor
|
I remember, there was some discussion about dropping a legacy right away, I just cant find it now, probably in archived channel 🙂 Should we mention this somewhere in Issue/PR? |
l2ysho
reviewed
May 19, 2026
l2ysho
approved these changes
May 19, 2026
Contributor
l2ysho
left a comment
l2ysho
left a comment
There was a problem hiding this comment.
nice job, left some nits, nonblocking
vladfrangu
approved these changes
May 19, 2026
Member
vladfrangu
left a comment
vladfrangu
left a comment
There was a problem hiding this comment.
Please update the PR title to match our structure and drop the legacy mention since that's gone now
Co-authored-by: Richard Solar <solar.richard@gmail.com>
patrikbraborec
changed the title
vladfrangu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli_commandtelemetry event for every CLI commandcli_command_pushfor backward compatibilityPromise.allSettledso one failure does not block the othercommandStringpayloadCloses #1132
Testing
corepack pnpm vitest run test/local/lib/command-framework/telemetry-event-name.test.tsgit diff --checkNote:
corepack pnpm tsc --noEmitcurrently fails on an unrelated existing type error insrc/lib/consts.ts:META_ORIGINS.CIis not present in the installed@apify/conststype.