Skip to content

fix: regenerate Chart.lock, clean up .gitignore, add Chart.lock CI validation #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nic-6443 merged 3 commits into from
Mar 25, 2026
Merged

fix: regenerate Chart.lock, clean up .gitignore, add Chart.lock CI validation #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd13ef8
fix: regenerate developer-portal-fe Chart.lock with valid digest
nic-6443 Mar 25, 2026
860071c
fix: clean up .gitignore and add Chart.lock validation to CI
nic-6443 Mar 25, 2026
a32f7d7
refactor: consolidate Chart.lock validation into single container
nic-6443 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,23 @@ jobs:
--charts charts/gateway \
--charts charts/ingress-controller'

- name: Verify Chart.lock files
run: |
docker run --rm --interactive --network host \
--volume "$PWD:/workdir" \
--workdir /workdir \
quay.io/helmpack/chart-testing:v3.10.1 sh -c '
helm repo add bitnami https://charts.bitnami.com/bitnami && \
helm repo add apisix https://charts.apiseven.com && \
helm repo add jaegertracing https://jaegertracing.github.io/helm-charts && \
for chart_dir in charts/*/; do
if [ -f "${chart_dir}Chart.lock" ]; then
echo "Verifying ${chart_dir}Chart.lock..."
helm dependency build "${chart_dir}"
fi
done
'

- name: Setup Kubernetes
uses: engineerd/setup-kind@v0.5.0
with:
Expand Down
4 changes: 1 addition & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
.DS_Store
.idea
charts/api7-gateway/charts
charts/api7-dashboard/charts
charts/devportal/charts
charts/*/charts
images
res
4 changes: 2 additions & 2 deletions charts/developer-portal-fe/Chart.lock
View file
Open in desktop
Copy link
Contributor Author

@nic-6443 nic-6443 Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can CI be added to detect this issue in advance?

Copy link
Contributor Author

@nic-6443 nic-6443 Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. The existing Helm chart CI already runs helm lint and helm install but doesn't verify the lock file. Adding a helm dependency build step to the CI workflow would catch this — it fails when the lock digest doesn't match.

I'll add a validation step to the CI in this PR.

Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ dependencies:
- name: postgresql
repository: https://charts.bitnami.com/bitnami
version: 12.12.10
digest: sha256:c3d1e1b7e4e1f5f5e4a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0
generated: "2024-03-23T09:28:00Z"
digest: sha256:3b8c03cf5b8742b8110494d29a4793f20920294a504bd85940d02bb00d0bc0ea
generated: "2026-03-25T17:04:07.589986044+08:00"
Loading