#38 ensure that headers and status code get written, even if nothing …#39
Open
UnquietCode wants to merge 1 commit intoapex:masterfrom
Open
#38 ensure that headers and status code get written, even if nothing …#39UnquietCode wants to merge 1 commit intoapex:masterfrom
UnquietCode wants to merge 1 commit intoapex:masterfrom
Conversation
…ing was ever written. This better aligns with the golang http package's own behavior to write on close.
|
Bump |
|
While we wait for merge, use this PR with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#38 ensure that headers and status code get written, even if nothing was ever written. This better aligns with the golang http package's own behavior to write on close.