Exclude header and footer from pagefind analysis#638
Merged
Conversation
Contributor
|
@Paul-TT did you ever test this? I believe you asked me about it a couple weeks ago. |
Contributor
Author
|
There is a preview site which shows it in action, see initial comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present, the contents of page headers and footers are included in the pagefind search.
This means that it is very difficult to search for actual references to words that appear in a header or footer.
For example, a search for Newsroom generates 175 hits, most of which are just links.
However, with the PR applied, there are just two hits:
https://www-search-body-only.staged.apache.org/