Skip to content

[master] WICKET-7169 - Make maxPartHeaderSize configurable#1383

Merged
martin-g merged 4 commits intoapache:masterfrom
renoth:master
Feb 25, 2026
Merged

[master] WICKET-7169 - Make maxPartHeaderSize configurable#1383
martin-g merged 4 commits intoapache:masterfrom
renoth:master

Conversation

@renoth
Copy link
Contributor

@renoth renoth commented Feb 23, 2026

For the 11.x Branch

fileUpload.setMaxFileCount(getFileCountMax());

fileUpload.setMaxPartHeaderSize(
Application.get().getApplicationSettings().getDefaultMaximumPartHeaderSize());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a protected int getDefaultMaximumPartHeaderSize() { return Application.get().getApplicationSettings().getDefaultMaximumPartHeaderSize(); } and use it here.

Same as the other getters above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@renoth
Copy link
Contributor Author

renoth commented Feb 25, 2026

Somehow FileUploadTest fails because of changes in commons-fileupload or commons-io ...

java.lang.IllegalStateException: The file item has not been fully read.

at org.apache.commons.fileupload2.core.DiskFileItem.getInputStream(DiskFileItem.java:449)
at org.apache.wicket.markup.html.form.upload.FileUpload.getInputStream(FileUpload.java:217)
at org.apache.wicket.markup.html.form.upload.FileUploadTest.getInputStream(FileUploadTest.java:86)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@martin-g martin-g changed the title WICKET-7169 [master] WICKET-7169 Feb 25, 2026
@martin-g martin-g changed the title [master] WICKET-7169 [master] WICKET-7169 - Make maxPartHeaderSize configurable Feb 25, 2026
@martin-g martin-g merged commit 0f12d0c into apache:master Feb 25, 2026
2 checks passed
@martin-g
Copy link
Member

Thank you, @renoth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants