Skip to content

fix(backend): Update PHYSICAL_ADDRESS_EXPIRATION_TIME_HRS to 24hrs #4269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carloea2 wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −2
Open

fix(backend): Update PHYSICAL_ADDRESS_EXPIRATION_TIME_HRS to 24hrs #4269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
224c4ff
v1
carloea2 Mar 7, 2026
a81a3c2
Merge branch 'main' into fix/lakefs-upload-time
carloea2 Mar 7, 2026
bf61306
v2
carloea2 Mar 7, 2026
240f474
Merge branch 'fix/lakefs-upload-time' of https://github.com/carloea2/…
carloea2 Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion common/workflow-core/src/main/scala/org/apache/texera/service/util/S3StorageClient.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ import scala.jdk.CollectionConverters._
object S3StorageClient {
val MINIMUM_NUM_OF_MULTIPART_S3_PART: Long = 5L * 1024 * 1024 // 5 MiB
val MAXIMUM_NUM_OF_MULTIPART_S3_PARTS = 10_000
val PHYSICAL_ADDRESS_EXPIRATION_TIME_HRS = 6
//Keep on sync with LakeFS https://github.com/treeverse/lakeFS/pull/10180
val PHYSICAL_ADDRESS_EXPIRATION_TIME_HRS = 24

// Initialize MinIO-compatible S3 Client
private lazy val s3Client: S3Client = {
Expand Down
2 changes: 1 addition & 1 deletion file-service/src/test/scala/org/apache/texera/service/resource/DatasetResourceSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,7 +905,7 @@ class DatasetResourceSpec
uploadPart(filePath, 1, minPartBytes(1.toByte)).getStatus shouldEqual 200
fetchPartRows(oldUploadId).find(_.getPartNumber == 1).get.getEtag.trim should not be ""

// Age the session so it is definitely expired (> PHYSICAL_ADDRESS_EXPIRATION_TIME_HRS = 6)
// Age the session so it is definitely expired (> PHYSICAL_ADDRESS_EXPIRATION_TIME_HRS)
val expireHrs = S3StorageClient.PHYSICAL_ADDRESS_EXPIRATION_TIME_HRS

getDSLContext
Expand Down
Loading