Fix timer and client leak in OpenSearch JSONResourceWrapper#1866
Merged
Fix timer and client leak in OpenSearch JSONResourceWrapper#1866
Conversation
The Timer and RestHighLevelClient were created inside an anonymous TimerTask with no way to cancel or close them. The timer thread runs forever and the client's connection pool is never shut down. Store both as instance fields and override cleanup() to cancel the timer and close the client. cleanup() is called by ParseFilters during bolt cleanup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rzo1
approved these changes
Apr 2, 2026
Contributor
|
Needs checkstyle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimerandRestHighLevelClientwere created inside an anonymousTimerTaskwith no way to cancel or close them — the timer thread runs forever and the client's connection pool is never shut downcleanup()to cancel the timer and close the clientcleanup()is called byParseFiltersduring bolt cleanup, so this is properly wired inTest plan
mvn compile -pl external/opensearch -am🤖 Generated with Claude Code