Fix double-close race on static client in OpenSearch AbstractSpout#1864
Merged
Fix double-close race on static client in OpenSearch AbstractSpout#1864
Conversation
The static client field is initialized under synchronized(AbstractSpout.class), but close() was unsynchronized, allowing multiple spout instances to close the same client concurrently. Additionally, client was never set to null after closing, so the null check provided no protection against double-close. Synchronize close() on AbstractSpout.class and set client to null after closing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rzo1
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clientfield is initialized undersynchronized(AbstractSpout.class), butclose()was unsynchronized, allowing multiple spout instances to close the same client concurrentlyclientwas never set tonullafter closing, so the null check provided no protection against double-closeclose()onAbstractSpout.classand setclient = nullafter closingTest plan
mvn compile -pl external/opensearch -am🤖 Generated with Claude Code