Skip to content

Fix thread-safety and minor issues in OkHttp protocol #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnioche merged 1 commit into from
Apr 2, 2026
+4 −4
Merged

Fix thread-safety and minor issues in OkHttp protocol #1862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/src/main/java/org/apache/stormcrawler/protocol/okhttp/HttpProtocol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@
import java.security.cert.CertificateException;
import java.util.ArrayList;
import java.util.Base64;
import java.util.HashMap;
import java.util.LinkedList;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.TimeUnit;
import javax.net.ssl.HostnameVerifier;
import javax.net.ssl.SSLContext;
Expand Down Expand Up @@ -98,7 +98,7 @@ public class HttpProtocol extends AbstractHttpProtocol {
private final List<KeyValue> customRequestHeaders = new LinkedList<>();

// track the time spent for each URL in DNS resolution
private final Map<String, Long> DNStimes = new HashMap<>();
private final Map<String, Long> DNStimes = new ConcurrentHashMap<>();

private OkHttpClient.Builder builder;

Expand Down Expand Up @@ -186,7 +186,7 @@ public void configure(Config conf) {
break;
}
}
if (protocols.size() > 0) {
if (!protocols.isEmpty()) {
LOG.info("Using protocol versions: {}", protocols);
builder.protocols(protocols);
}
Expand Down Expand Up @@ -512,7 +512,7 @@ private byte[] toByteArray(

// okhttp may fetch more content than requested, quickly "increment"
// bytes
bytesRequested = (int) source.getBuffer().size();
bytesRequested = source.getBuffer().size();
}
int bytesToCopy = (int) source.getBuffer().size(); // bytesBuffered
if (maxContent != -1 && bytesToCopy > maxContent) {
Expand Down