Add bolt-level timeout for fetcher threads#1861
Merged
Conversation
Wraps protocol.getProtocolOutput() in a Future with a configurable hard timeout (fetcher.thread.timeout). When a fetch exceeds the timeout the future is cancelled, the URL is marked as FETCH_ERROR, and the thread moves on. Disabled by default (-1). Fixes #996 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Julien Nioche <julien@digitalpebble.com>
rzo1
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetcher.thread.timeout) that wrapsprotocol.getProtocolOutput()calls in bothFetcherBoltandSimpleFetcherBoltFETCH_ERROR, and the fetcher thread moves on to the next item-1), relying on protocol-level socket timeouts onlyPreviously, if the protocol layer hung beyond socket timeouts (due to client library bugs, misconfigured timeouts, or misbehaving proxies), fetcher threads would block indefinitely with no recovery mechanism.
Fixes #996
Test plan
testThreadTimeouttest inAbstractFetcherBoltTest(inherited by bothFetcherBoltTestandSimpleFetcherBoltTest) — uses WireMock with a 10s delay and a 2s bolt timeout to verify the thread is reclaimed and aFETCH_ERRORis emitted🤖 Generated with Claude Code