Skip to content

[SPARK-52428] Fix show() to print table directly instead of double-wrapping #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rafafrdz wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

[SPARK-52428] Fix show() to print table directly instead of double-wrapping #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions crates/connect/src/dataframe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ use spark::relation::RelType;
pub use spark::write_operation::SaveMode;

use arrow::array::PrimitiveArray;
use arrow::array::{Array, StringArray};
use arrow::datatypes::{DataType, Float64Type};
use arrow::json::ArrayWriter;
use arrow::record_batch::RecordBatch;
Expand Down Expand Up @@ -1038,6 +1039,15 @@ impl DataFrame {

let rows = self.spark_session.client().to_arrow(plan).await?;

// ShowString returns a single-column RecordBatch with the formatted table as a string.
// Extract and print the string directly instead of wrapping it in another table.
if let Some(arr) = rows.column(0).as_any().downcast_ref::<StringArray>() {
if arr.len() > 0 {
println!("{}", arr.value(0));
return Ok(());
}
}

Ok(pretty::print_batches(&[rows])?)
}

Expand Down