Skip to content

[SPARK-52428] Harden DataFrame error handling#25

Open
rafafrdz wants to merge 1 commit intoapache:masterfrom
rafafrdz:hardening-dataframe-error-handling
Open

[SPARK-52428] Harden DataFrame error handling#25
rafafrdz wants to merge 1 commit intoapache:masterfrom
rafafrdz:hardening-dataframe-error-handling

Conversation

@rafafrdz
Copy link
Copy Markdown

Summary

  • Remove 2 panic!() calls in corr() and cov(), replace with Err(SparkError::AnalysisException(...))
  • Remove 3 unimplemented!() in columns(), count(), dtypes(), replace with Err(SparkError::NotYetImplemented(...))
  • Replace 7 check_same_session().unwrap() with ? propagation (return types updated to Result)
  • Replace expect()/unwrap() on schema responses and type downcasts with ok_or()
  • Replace client.analyze().await.unwrap() with ? in persist()/unpersist()

Test plan

  • cargo build passes
  • cargo test unit tests pass
  • cargo fmt -- --check passes

@rafafrdz rafafrdz force-pushed the hardening-dataframe-error-handling branch from 3131db5 to 1831489 Compare March 29, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant