SOLR-18034: Add index-time nested vector expansion tests#4160
SOLR-18034: Add index-time nested vector expansion tests#4160arup-chauhan wants to merge 1 commit intoapache:mainfrom
Conversation
|
Hello everyone. This PR is for the index-time part of SOLR-18034 (test coverage validating multivalued dense vector expansion into nested children) Scope is intentionally narrow: this does not introduce new query-time behavior and keeps single-valued vector behavior unchanged, so risk is low, and boundaries stay aligned with related issues. If this split looks good, I’ll proceed with the follow-up lifecycle-safety work in a second PR. |
|
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the dev@solr.apache.org mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution! |
|
@epugh, I hope you are doing well. Just wanted to bring attention to this one. This is the follow-up for the test coverage of the nested logic issue. P.S: We talked about this on Slack. I have talked about bringing attention to this via the mailing list. |
|
@dsmiley i wanted to make sure you saw this? You have deeper knowledge in how parent child works!!! |
Description
This PR adds focused index-time test coverage for SOLR-18034 to validate how nested vector documents are constructed from multi-valued dense vectors.
The goal here is to make the existing behavior explicit and regression-safe before any broader lifecycle work.
Context from issue discussion
Issue: SOLR-18034
From the discussion, the scope is server-side indexing assistance for parent/child modeling of nested vectors (aligned with nested-vector direction from SOLR-17736, while avoiding overlap with broader multi-valued vector/query-time scope in SOLR-18074
This PR is intentionally scoped as PR-1: index-time behavior validation.
Changes
processing.
idformat_nest_parent__nest_path_Behavior / Safety
Validation
Executed and passing:
./gradlew :solr:core:test --tests org.apache.solr.update.TestNestedUpdateProcessor./gradlew tidy./gradlew check -x testResult: all commands completed successfully for this branch.
Follow-ups
Planned next step (PR-2), based on maintainer feedback: