SOLR-18099: CollapseQParser extensibility#4112
Open
dsmiley wants to merge 21 commits intoapache:mainfrom
Open
Conversation
And allow custom GroupHeadSelector building
github-actions
Bot
added
documentation
and remove many needsScores4Collapsing fields/passing
mlbiscoc
approved these changes
Feb 12, 2026
| SORT, | ||
| SCORE; | ||
| SCORE, | ||
| CUSTOM; |
Contributor
There was a problem hiding this comment.
Maybe a point here that CUSTOM is specifically for subclasses? It's currently not used anywhere including tests and someone may remove it by mistake thinking no use.
OrdFieldValueCollector, IntFieldValueCollector: Replaced a strategy pattern with inheritance. Simpler. Easier to customize. Use Builder instead of passing tons of params around. Organize fields on the collectors.
… pattern: 1. complete() is now final on the base class, with abstract callbacks: getCollapsedDisi() (returns collapsed doc IDs) and getCollapsedScores() (returns a Scorable per segment) 2. CachedScoreScorable — new abstract Scorable subclass that caches score() by doc ID, delegating to computeScore(int globalDoc) 3. scoreNullGroup() — base class helper extracting null-group score logic from complete() 4. contexts changed from LeafReaderContext[] to List<LeafReaderContext> 5. Scoring setup moved from getCollapsedDisi() to getCollapsedScores() (lazy init) in both Ord collectors 6. Removed advanceCompleteSegment() and getGroupHeadScore() abstract methods (replaced by getCollapsedScores)
…, thus avoiding questionable eager detection algorithm. An optimization.
valueCount moved from builder to collector constructor Removed redundant needsScores4Collapsing fields Removed deprecated things
Move boostDocs initialization.
Refactor BoostedDocsCollector a little. DynamicMap: track size
initializeCollection clarity
|
This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be familiar with the code area and/or notify the dev@solr.apache.org mailing list. To exempt this PR from being marked as stale, make it a draft PR or add the label "exempt-stale". If left unattended, this PR will be closed after another 60 days of inactivity. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18099
I did in a series of clean steps, separate commits.
BTW my approach was to take a custom subclass I have at work and put it in the source tree somewhere, and then iteratively made the refactorings (manually + IntelliJ refactorings) until the subclass compiled. I also made some tweaks to it. IntelliJ did the "record" conversion as well.
It's a shame this source file is so massive. Ideally we'd break it up at some point.
Also, the extensibility here is limited to String fields.