[GH-2888] Flink bindings for Box2D Phase 1 surface#2906
Merged
jiayuasu merged 2 commits intoapache:masterfrom May 7, 2026
Merged
[GH-2888] Flink bindings for Box2D Phase 1 surface#2906jiayuasu merged 2 commits intoapache:masterfrom
jiayuasu merged 2 commits intoapache:masterfrom
Conversation
Mirrors the Phase 1 SQL surface in Flink: - Box2DTypeSerializer (RAW Flink TypeSerializer for Box2D) - ST_Box2D scalar in Functions - ST_MakeBox2D, ST_GeomFromBox2D scalars in Constructors - ST_Extent aggregate in Aggregators - Box2D eval overloads on ST_XMin, ST_XMax, ST_YMin, ST_YMax, ST_AsText - Catalog registration for the four new top-level functions Tests in FunctionTest, ConstructorTest, AggregatorTest cover the happy path, NULL/empty propagation, and the dimensionality dispatch in ST_GeomFromBox2D. Closes apache#2888.
(0, 0) is Null Island — equator × prime meridian — a real point. A zero-zero Box2D used as an aggregation seed or initial value would silently include the origin in every result. Box2D has no in-band empty marker; absence is represented by SQL NULL. Returning null from createInstance() is the honest default and matches our type contract. The ST_Extent aggregator was never affected (it uses Accumulators.Envelope with +inf/-inf, not Box2D), but the precedent in createInstance() should not be a footgun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes Flink bindings for Box2D scalar functions and ST_Extent #2888What changes were proposed in this PR?
Mirrors the Phase 1 Box2D SQL surface in the Flink module.
Type system
flink/src/main/java/org/apache/sedona/flink/Box2DTypeSerializer.java— FlinkTypeSerializer<Box2D>. Same shape asGeometryTypeSerializer(used as aRAWdata type via@DataTypeHint(rawSerializer = ..., bridgedTo = ...)). Encodes a presence byte plus four doubles.Scalars and aggregate
ST_Box2D(geom)FunctionsST_MakeBox2D(p1, p2)ConstructorsST_GeomFromBox2D(box)ConstructorsST_Extent(geom)AggregatorsST_XMin/XMax/YMin/YMax(box)Functionseval(Box2D)overloads on the existing classesST_AsText(box)Functionseval(Box2D)overload returningBOX(...)Plus Catalog registration for the four new top-level functions (
ST_Box2D,ST_MakeBox2D,ST_GeomFromBox2D,ST_Extent).How was this patch tested?
flink/src/test/.../FunctionTest.java—testBox2D(happy path + NULL propagation),testBox2DAsTextAndAccessors(BOX format and the four 2D accessors against a Box2D value).flink/src/test/.../ConstructorTest.java—testMakeBox2D(happy path),testGeomFromBox2D(POLYGON + degenerate POINT cases through ST_AsText).flink/src/test/.../AggregatorTest.java—testExtent(happy path),testExtent_EmptyAndNullGeometries(NULL/empty input → NULL).Did this PR include necessary documentation updates?