feat:(Console): add search feature#187
Merged
jbonofre merged 4 commits intoapache:mainfrom Mar 20, 2026
Merged
Conversation
jbonofre
approved these changes
Mar 15, 2026
| * "a" → does NOT match "online_store" ✗ (no word starts with "a") | ||
| * "a" → matches "accounting" ✓ (word "accounting" starts with "a") | ||
| */ | ||
| function matchesQuery(text: string, query: string): boolean { |
Member
There was a problem hiding this comment.
This function only matches single-word queries: it takes the query as a single token.
For instance a namespace like "my namespace" won't match anything.
Maybe we can consider splitting the query on whitespace and requiring each word to match at least one segment.
That's not a blocker but worth to consider.
Contributor
Author
There was a problem hiding this comment.
Updated the logic to split on whitespace and match segment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a search dialog to the console to allowing users to quickly navigate to catalogs, namespaces, tables, views, and principals
Features:
Limitations:
Screen.Recording.2026-03-12.at.8.11.58.PM.mov