Skip to content

MINIFICPP-2744 Pin libc++ version in clang CI job#2130

Open
lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez:MINIFICPP-2744
Open

MINIFICPP-2744 Pin libc++ version in clang CI job#2130
lordgamez wants to merge 1 commit intoapache:mainfrom
lordgamez:MINIFICPP-2744

Conversation

@lordgamez
Copy link
Contributor

The github actions ubuntu image uses a different llvm repository which overrides the libc++ version needed for the clang-20 compilation. Pin the libc++ version on the runner to avoid the version conflict.

https://issues.apache.org/jira/browse/MINIFICPP-2744


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

The github actions ubuntu image uses a different llvm repository which
overrides the libc++ version needed for the clang-20 compilation. Pin
the libc++ version on the runner to avoid the version conflict.
@lordgamez lordgamez marked this pull request as ready for review March 6, 2026 14:56
@szaszm
Copy link
Member

szaszm commented Mar 6, 2026

maybe we should remove whatever llvm repository github added, or use that instead, if the right versions are present in it

@lordgamez
Copy link
Contributor Author

maybe we should remove whatever llvm repository github added, or use that instead, if the right versions are present in it

Unfortunately we cannot use it because it contains libc++23 and we need libc++20 to be compatible with the current clang-20 compiler. Removing it would be more tricky as I cannot see the internals of the docker image.

martinzink pushed a commit to martinzink/nifi-minifi-cpp that referenced this pull request Mar 9, 2026
The github actions ubuntu image uses a different llvm repository which overrides the libc++ version needed for the clang-20 compilation. Pin the libc++ version on the runner to avoid the version conflict.

Closes apache#2130

Signed-off-by: Martin Zink <martinzink@apache.org>
@martinzink martinzink added the priority Review these first label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix priority Review these first

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants