KNOX-3279 - REST Catalog dispatch implementation for including configurable metadata as outbound request headers#1182
Open
pzampino wants to merge 1 commit intoapache:masterfrom
Open
KNOX-3279 - REST Catalog dispatch implementation for including configurable metadata as outbound request headers#1182pzampino wants to merge 1 commit intoapache:masterfrom
pzampino wants to merge 1 commit intoapache:masterfrom
Conversation
moresandeep
requested changes
Mar 23, 2026
...og/src/main/java/org/apache/knox/gateway/service/restcatalog/TokenMetadataHeaderHandler.java
Outdated
Show resolved
Hide resolved
...og/src/main/java/org/apache/knox/gateway/service/restcatalog/TokenMetadataHeaderHandler.java
Outdated
Show resolved
Hide resolved
...og/src/main/java/org/apache/knox/gateway/service/restcatalog/TokenMetadataHeaderHandler.java
Show resolved
Hide resolved
...og/src/main/java/org/apache/knox/gateway/service/restcatalog/TokenMetadataHeaderHandler.java
Outdated
Show resolved
Hide resolved
Test Results7 tests 7 ✅ 1s ⏱️ Results for commit b0d3dd2. ♻️ This comment has been updated with latest results. |
smolnar82
requested changes
Mar 23, 2026
...stcatalog/src/main/java/org/apache/knox/gateway/service/restcatalog/RestCatalogDispatch.java
Outdated
Show resolved
Hide resolved
...catalog/src/main/java/org/apache/knox/gateway/service/restcatalog/RestCatalogHaDispatch.java
Outdated
Show resolved
Hide resolved
...og/src/main/java/org/apache/knox/gateway/service/restcatalog/TokenMetadataHeaderHandler.java
Outdated
Show resolved
Hide resolved
...og/src/main/java/org/apache/knox/gateway/service/restcatalog/TokenMetadataHeaderHandler.java
Outdated
Show resolved
Hide resolved
...og/src/main/java/org/apache/knox/gateway/service/restcatalog/TokenMetadataHeaderHandler.java
Show resolved
Hide resolved
…urable metadata as outbound request headers
moresandeep
approved these changes
Mar 23, 2026
...og/src/main/java/org/apache/knox/gateway/service/restcatalog/TokenMetadataHeaderHandler.java
Outdated
Show resolved
Hide resolved
...og/src/main/java/org/apache/knox/gateway/service/restcatalog/TokenMetadataHeaderHandler.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added custom dispatches for the REST Catalog API (ICEBERG-REST) which can convey configurable token metadata as headers in the outbound dispatch request (e.g., userName --> X-Knox-Meta-userName header).
How was this patch tested?
Added two new tests for the respective dispatches (RestCatalogDispatchTest, RestCatalogHaDispatchTest), ran a full
clean verify, and manually tested with a local installation.