KAFKA-20348: Move ControllerRegistrationManager to server module#21854
Merged
mimaison merged 2 commits intoapache:trunkfrom Mar 23, 2026
Merged
KAFKA-20348: Move ControllerRegistrationManager to server module#21854mimaison merged 2 commits intoapache:trunkfrom
mimaison merged 2 commits intoapache:trunkfrom
Conversation
clolov
approved these changes
Mar 23, 2026
Contributor
clolov
left a comment
clolov
left a comment
There was a problem hiding this comment.
If the tests pass then this looks good to me 😊
| logger.info("Found registration for {} instead of our incarnation.", curRegistration.incarnationId()); | ||
| registeredInLog = false; | ||
| } else { | ||
| logger.info("Our registration has been persisted to the metadata logger."); |
Contributor
There was a problem hiding this comment.
Nit: This used to be
...persisted to the metadata log.")
Member
Author
There was a problem hiding this comment.
Haha good catch!
That's why you should use the IDE rename feature instead of doing replace all from the CLI
|
|
||
| // Create the registration manager, which handles sending KIP-919 controller registrations. | ||
| registrationManager = new ControllerRegistrationManager(config.nodeId, | ||
| clusterId, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't move ControllerRegistrationManagerTest yet due to dependencies
on KafkaConfig.