KAFKA-14474: Move OffsetIndex to storage module#13009
Merged
ijuma merged 1 commit intoapache:trunkfrom Dec 20, 2022
Merged
Conversation
3 tasks
ijuma
force-pushed
the
kafka-14474-move-offset-index-to-storage
branch
4 times, most recently
from
8c169ab to
bfc38de
Compare
ijuma
force-pushed
the
kafka-14474-move-offset-index-to-storage
branch
from
bfc38de to
b68f9c6
Compare
For broader context on this change, please check: KAFKA-14470: Move log layer to storage module
ijuma
force-pushed
the
kafka-14474-move-offset-index-to-storage
branch
from
b68f9c6 to
3fd84ef
Compare
Member
Author
|
Test failures look unrelated, re-running just in case. |
junrao
approved these changes
Dec 20, 2022
| } | ||
|
|
||
| } No newline at end of file | ||
| } |
Member
Author
There was a problem hiding this comment.
@junrao I think most editors expect a new line at the end. For example, IntelliJ adds it automatically after I delete the new line and save the file (I tried it just now). And vim doesn't even show that there is a new line. So, I think we should probably leave it in.
Contributor
There was a problem hiding this comment.
Thanks for the explanation. Sounds good.
Member
Author
|
Failures are unrelated. |
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
For broader context on this change, please check: * KAFKA-14470: Move log layer to storage module Reviewers: Jun Rao <junrao@gmail.com>, Satish Duggana <satishd@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For broader context on this change, please check:
Committer Checklist (excluded from commit message)