KAFKA-14472: Move TransactionIndex and related to storage module#12996
Merged
ijuma merged 1 commit intoapache:trunkfrom Dec 19, 2022
Merged
KAFKA-14472: Move TransactionIndex and related to storage module#12996ijuma merged 1 commit intoapache:trunkfrom
ijuma merged 1 commit intoapache:trunkfrom
Conversation
ijuma
force-pushed
the
kafka-14470-transaction-index-storage
branch
3 times, most recently
from
7dbb556 to
f265b48
Compare
3 tasks
ijuma
force-pushed
the
kafka-14470-transaction-index-storage
branch
from
f265b48 to
b8fa3c0
Compare
Member
Author
|
@junrao Would you be able to review this PR? |
ijuma
force-pushed
the
kafka-14470-transaction-index-storage
branch
2 times, most recently
from
d1fde75 to
372e4e4
Compare
ijuma
force-pushed
the
kafka-14470-transaction-index-storage
branch
from
372e4e4 to
1603df5
Compare
Member
Author
|
Failures are unrelated. |
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
…che#12996) For broader context on this change, please check: * KAFKA-14470: Move log layer to storage module Reviewers: Jun Rao <junrao@gmail.com>, Satish Duggana <satishd@apache.org>
chia7712
reviewed
Mar 8, 2026
| if (channel == null) | ||
| return Collections.emptyList(); | ||
|
|
||
| PrimitiveRef.IntRef position = PrimitiveRef.ofInt(0); |
Member
There was a problem hiding this comment.
This will be an issue if we create multiple Iterator instances, since they share the same position object
we will fix it in #21577 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For broader context on this change, please check:
Committer Checklist (excluded from commit message)