Prevent workflow command injection in verify action build output#648
Merged
Prevent workflow command injection in verify action build output#648
Conversation
Wrap the verify-action-build.py invocation with ::stop-commands:: so that strings like ##[add-matcher] or ::error:: in action diffs are not interpreted as GitHub Actions workflow commands.
dave2wave
approved these changes
Apr 1, 2026
Member
dave2wave
left a comment
dave2wave
left a comment
There was a problem hiding this comment.
I was wondering about those errors ...
Member
Author
I just asked AI - Copilot to diagnose and Claude to fix it. |
Member
Author
|
BTW. The "explain error" button in GH Copilot is actuallly quite useful for those things - otherwise I would not even notice the error in the middle of the diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify-action-build.pyinvocation with::stop-commands::<token>/::<token>::using a random UUID##[add-matcher],::error::,::warning::in action diff output from being interpreted as GitHub Actions workflow commandsTest plan
Generated with Claude Code