Skip to content

Improve verify-action-build.py CI output and add security review checklist#647

Merged
potiuk merged 1 commit intomainfrom
improve-verify-action-build
Apr 1, 2026
Merged

Improve verify-action-build.py CI output and add security review checklist#647
potiuk merged 1 commit intomainfrom
improve-verify-action-build

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented Apr 1, 2026

Summary

  • Suppress Rich spinner/status progress in CI (force_interactive=False) to reduce noise in workflow logs
  • Print exit code before exiting for easier CI debugging
  • Add a Security Review Checklist section to the README covering common attack vectors to watch for when reviewing actions (credential exfiltration, arbitrary code execution, supply-chain risks, etc.)
  • Reference the checklist URL in --help epilog and in the RESULT panel shown after each verification
  • Quote ${{ github.event.pull_request.number }} in the CI workflow to prevent word splitting

Test plan

  • Run uv run utils/verify-action-build.py --help and confirm the epilog shows the checklist URL
  • Run a verification in CI mode (--ci) and confirm no spinners appear and exit code is printed
  • Verify the README anchor #security-review-checklist resolves correctly on GitHub

Generated with Claude Code

…klist

- Suppress Rich spinner progress in CI by setting force_interactive=False
- Print exit code before exiting for CI visibility
- Add security review checklist to README covering common attack vectors
- Reference the checklist in --help epilog and RESULT panel
- Quote PR number in workflow to prevent word splitting
Copy link
Copy Markdown
Member

@dave2wave dave2wave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk potiuk merged commit 57e4ff8 into main Apr 1, 2026
7 checks passed
@potiuk potiuk deleted the improve-verify-action-build branch April 1, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants