Skip to content

Add protected branches configuration for main branch #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dave2wave wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add protected branches configuration for main branch #642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c312b99
Add protected branches configuration for main branch
dave2wave Mar 31, 2026
de10bdc
Update main branch settings in .asf.yaml
dave2wave Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .asf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ github:
del_branch_on_merge: true
features:
issues: true
protected_branches:
main:
required_status_checks:
# strict means "Require branches to be up to date before merging".
strict: false
Comment on lines +25 to +27
Copy link
Copy Markdown
Contributor

@kevinjqliu kevinjqliu Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already the default value, but doesnt hurt to be explicit

required_pull_request_reviews:
dismiss_stale_reviews: false
Copy link
Copy Markdown
Contributor

@kevinjqliu kevinjqliu Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, dismiss_stale_reviews: false is the default but doesnt hurt to be explicit

require_code_owner_reviews: true
Copy link
Copy Markdown
Contributor

@kevinjqliu kevinjqliu Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we set this? default is false, who are the code owners ?

required_approving_review_count: 1
Copy link
Copy Markdown
Contributor

@kevinjqliu kevinjqliu Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


notifications:
commits: commits@infra.apache.org
Expand Down
Loading