Follow up on #638 - fix pypi publish action version handling#640
Merged
Conversation
The previous version (v1.12.4) should not have `keep: true` as it's not the newest version. Also updates README to better document the process of adding older vs newer versions of already approved actions. Generated-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dave2wave
approved these changes
Mar 31, 2026
Member
dave2wave
left a comment
dave2wave
left a comment
There was a problem hiding this comment.
LGTM - but maybe add a note that keep and expires_at are mutually exclusive. Does one take precedence over the other?
raboof
approved these changes
Apr 1, 2026
Member
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
good improvement, though the docs are getting hard to digest and in need of a good wider review at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #638 which was mistakenly merged too fast.
keep: truefrom the older pypa/gh-action-pypi-publish v1.12.4 — only the newest version (v1.13.0) should havekeep: trueTest plan
actions.ymlcorrectly marks only v1.13.0 withkeep: true🤖 Generated with Claude Code