Skip to content

Add lhotari/sandboxed-trivy-action v1.0.1#582

Merged
dave2wave merged 2 commits intoapache:mainfrom
lhotari:lh-sandboxed-trivy-action-v1.0.0
Apr 1, 2026
Merged

Add lhotari/sandboxed-trivy-action v1.0.1#582
dave2wave merged 2 commits intoapache:mainfrom
lhotari:lh-sandboxed-trivy-action-v1.0.0

Conversation

@lhotari
Copy link
Copy Markdown
Member

@lhotari lhotari commented Mar 24, 2026

Request for adding a new GitHub Action to the allow list

Overview

This action is forked from aquasecurity/trivy-action with security hardened by running Trivy inside a sandboxed Docker container. More details about the security hardening in the README file of the repository.
Credits to Aqua Security for the original action.

Name of action:
lhotari/sandboxed-trivy-action

URL of action:
https://github.com/lhotari/sandboxed-trivy-action
https://github.com/marketplace/actions/sandboxed-trivy

Version to pin to (hash only):
555963036b2012b44c1071508a236e569db28ebb

Permissions

No special permissions required.

Related Actions

This is a fork of https://github.com/aquasecurity/trivy-action

Checklist

You should be able to check most of these boxes for an action to be considered for review.
Please check all boxes that currently apply:

  • The action is listed in the GitHub Actions Marketplace
  • The action is not already on the list of approved actions
  • The action has a sufficient number of contributors or has contributors within the ASF community
  • The action has a clearly defined license
  • The action is actively developed or maintained
  • The action has CI/unit tests configured

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Mar 30, 2026

I am still a bit sceptical about trivy's abilities to do somethign "well". @raboof WDYT?

Copy link
Copy Markdown
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

Checked with enhanced verification for composite actions #629:

Image

Also manually inspected, it does sandbox trivy, so I would recommend to approve it.

I likely need one more person to approve it.

Copy link
Copy Markdown
Member

@dave2wave dave2wave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari changed the title Add lhotari/sandboxed-trivy-action v1.0.0 Add lhotari/sandboxed-trivy-action v1.0.1 Apr 1, 2026
@lhotari
Copy link
Copy Markdown
Member Author

lhotari commented Apr 1, 2026

@potiuk @dave2wave PTAL
I updated to v1.0.1, 555963036b2012b44c1071508a236e569db28ebb since I noticed that actions/cache was outdated and using node20 runtime which will be phased out later this year.

changes:
lhotari/sandboxed-trivy-action@f5a39c6...5559630

@lhotari lhotari requested review from dave2wave and potiuk April 1, 2026 15:16
Copy link
Copy Markdown
Member

@dave2wave dave2wave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upgraded SHA

@kevinjqliu
Copy link
Copy Markdown
Contributor

thanks! this is super helpful to unblock apache projects from using trivy.

Curious which commit from trivy was it forked from? I couldnt find a reference. Would be good for us to check that the original source code is forked from a "known good version"

@dave2wave
Copy link
Copy Markdown
Member

@lhotari would you either add the requested information to your action and provide the new SHA, or if the information is there provide a direct link that would help with approval.

@lhotari
Copy link
Copy Markdown
Member Author

lhotari commented Apr 1, 2026

thanks! this is super helpful to unblock apache projects from using trivy.

Curious which commit from trivy was it forked from? I couldnt find a reference. Would be good for us to check that the original source code is forked from a "known good version"

@kevinjqliu I forked off v0.35.0 (immutable tag 57a97c7e7821a5776cebc9bb87c984fa69cba8f1) of aquasecurity/trivy-action and adapted it to the sandboxed implementation.

@kevinjqliu
Copy link
Copy Markdown
Contributor

awesome thank you! i think it would be helpful to include that context in the projects README

@lhotari
Copy link
Copy Markdown
Member Author

lhotari commented Apr 1, 2026

awesome thank you! i think it would be helpful to include that context in the projects README

@kevinjqliu Thanks for the suggestion, added to README in lhotari/sandboxed-trivy-action@f34b732a.

Copy link
Copy Markdown
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

the underlying repo is forked from trivy's v0.35.0 release with commit hash 57a97c7e7821a5776cebc9bb87c984fa69cba8f1

This is mentioned by Trivy as a safe release, aquasecurity/trivy#10425

The action by default pulls the docker image aquasec/trivy:0.69.3@sha256:bcc376de8d77cfe086a917230e818dc9f8528e3c852f7b1aff648949b6258d1c
which i also validated against docker https://hub.docker.com/layers/aquasec/trivy/0.69.3/images/sha256-7228e304ae0f610a1fad937baa463598cadac0c2ac4027cc68f3a8b997115689

@dave2wave dave2wave merged commit 0e2e041 into apache:main Apr 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants