fix(gh-copilot): skip empty report responses for dates without Copilot data#8804
Merged
ewega merged 1 commit intoapache:mainfrom Mar 30, 2026
Merged
fix(gh-copilot): skip empty report responses for dates without Copilot data#8804ewega merged 1 commit intoapache:mainfrom
ewega merged 1 commit intoapache:mainfrom
Conversation
…t data GitHub's Copilot Usage Metrics Reports API returns HTTP 200 with body "" for dates before usage data was available, instead of returning a 404. The existing ignore404 callback does not catch this, so the ResponseParser attempts json.Unmarshal on "" which fails and crashes the collector pipeline. Add an isEmptyReport guard that detects empty/null bodies and returns nil so the collector silently skips those days. Fixes apache#8789
dosubot
bot
added
size:M
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents the gh-copilot metrics collectors from failing when GitHub’s Copilot Usage Metrics Reports API returns HTTP 200 with an empty/""/null body for days with no available Copilot usage data (instead of returning 404), by detecting and skipping those responses before JSON unmarshalling.
Changes:
- Added an
isEmptyReport([]byte) boolhelper to detect empty report metadata responses ("",null, empty/whitespace). - Updated enterprise/org/user metrics collectors to short-circuit and skip processing when an empty report is detected.
- Added unit tests covering
isEmptyReportedge cases.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| backend/plugins/gh-copilot/tasks/report_download_helper.go | Adds isEmptyReport helper to detect empty/""/null metadata bodies. |
| backend/plugins/gh-copilot/tasks/enterprise_metrics_collector.go | Skips parsing/processing when metadata body is detected as empty. |
| backend/plugins/gh-copilot/tasks/org_metrics_collector.go | Skips parsing/processing when metadata body is detected as empty. |
| backend/plugins/gh-copilot/tasks/user_metrics_collector.go | Skips parsing/processing when metadata body is detected as empty. |
| backend/plugins/gh-copilot/tasks/metrics_collector_test.go | Adds unit tests for isEmptyReport behaviors and edge cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@ewega any concerns with accepting this PR? |
Contributor
|
Hi, @ewega . Can you have a look at the PR when you find time? Thanks. |
ewega
approved these changes
Mar 30, 2026
Contributor
ewega
left a comment
ewega
left a comment
There was a problem hiding this comment.
LGTM! Apologies on getting back to you late
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub's Copilot Usage Metrics Reports API returns HTTP 200 with body
""for dates before usage data was available, instead of returning a 404. The existingignore404callback does not catch this, so theResponseParserattemptsjson.Unmarshalon""which fails and crashes the collector pipeline.Changes:
isEmptyReport(body []byte) boolhelper inreport_download_helper.gothat detects empty,"", ornullbodiesResponseParserin all three collectors (enterprise_metrics_collector.go,org_metrics_collector.go,user_metrics_collector.go) to returnnil, nilwhen an empty report is detected, so the collector silently skips those daysisEmptyReportcovering empty body,"",null, whitespace, and valid metadata casesFixes #8789
Test Plan
isEmptyReportcovering edge cases (empty body,"",null, whitespace, valid JSON)sincedate predating available usage data and confirm the collector no longer crashesMade with Cursor