Skip to content

fix(circleci): prevent negative workflow duration#8800

Open
varsis wants to merge 1 commit intoapache:mainfrom
varsis:fix/circleci-negative-duration
Open

fix(circleci): prevent negative workflow duration#8800
varsis wants to merge 1 commit intoapache:mainfrom
varsis:fix/circleci-negative-duration

Conversation

@varsis
Copy link
Copy Markdown
Contributor

@varsis varsis commented Mar 22, 2026

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

This PR ensures the calculated duration for CircleCI workflows is never a negative value. I've added a simple >= 0 check to the logic.

  • Updated logic
  • Updated fixtures to capture this edge case

Does this close any open issues?

Closes #8229

Screenshots

N/A

Other Information

N/A

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug labels Mar 22, 2026
@klesh
Copy link
Copy Markdown
Contributor

klesh commented Mar 23, 2026

Good job. Please resolve the conflict so I can merge it.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 23, 2026
@varsis varsis force-pushed the fix/circleci-negative-duration branch from 6c181d5 to 16d5d22 Compare March 23, 2026 20:21
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][CircleCi] Negative workflow duration

2 participants