fix(circleci): correct column name in incremental collection WHERE clause#8766
Open
jbsmith7741 wants to merge 1 commit intoapache:mainfrom
Open
fix(circleci): correct column name in incremental collection WHERE clause#8766jbsmith7741 wants to merge 1 commit intoapache:mainfrom
jbsmith7741 wants to merge 1 commit intoapache:mainfrom
Conversation
…ause. use already name columns created_at rather than created_date Fixes apache#8497
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a MySQL error that causes every incremental CircleCI sync to fail
after the first successful run.
Both
workflow_collector.goandjob_collector.gobuild aWHERE created_date > ?clause whenisIncremental = true, but theactual column in
_tool_circleci_workflowsiscreated_at(derivedfrom the Go struct field
CircleciWorkflow.CreatedAt).Fix: change the two
WHEREclause strings fromcreated_datetocreated_atto match the actual schema. No model changes, nomigration scripts, and no other files are touched.
Does this close any open issues?
Closes #8497
Screenshots
NA
Other Information
alternative solution would be to rename the column to create_date which would require a DB migration script and changes through the code. If desired I can switch to that solution, but this was the simplest fix with the less amount of code changes.