Enforce RST_STREAM payload length regardless of stream existence#638
Open
arturobernalg wants to merge 1 commit intoapache:masterfrom
Open
Enforce RST_STREAM payload length regardless of stream existence#638arturobernalg wants to merge 1 commit intoapache:masterfrom
arturobernalg wants to merge 1 commit intoapache:masterfrom
Conversation
RFC 9113 requires RST_STREAM frames to carry exactly 4 octets of payload; otherwise the endpoint MUST treat it as a connection error of type FRAME_SIZE_ERROR.
ok2c
reviewed
Feb 23, 2026
| throw new H2ConnectionException(H2Error.FRAME_SIZE_ERROR, "Invalid RST_STREAM frame payload"); | ||
| } | ||
| final int errorCode = payload.getInt(); | ||
| final int errorCode = payload.getInt(payload.position()); |
Member
There was a problem hiding this comment.
@arturobernalg Why payload.getInt(payload.position());? Was it wrong?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC9113 6.4. RST_STREAM A RST_STREAM frame with a length other than 4 octets MUST be treated as a connection error (Section 5.4.1) of type FRAME_SIZE_ERROR.