TTP/2: validate pseudo-headers in inbound request trailers#637
Open
arturobernalg wants to merge 1 commit intoapache:masterfrom
Open
TTP/2: validate pseudo-headers in inbound request trailers#637arturobernalg wants to merge 1 commit intoapache:masterfrom
arturobernalg wants to merge 1 commit intoapache:masterfrom
Conversation
ServerH2StreamHandler forwarded inbound request trailers (HEADERS in BODY
state) directly to AsyncServerExchangeHandler.streamEnd(...) without
validating trailer semantics. This allowed pseudo-header fields (':...')
to slip through on the server path.
ok2c
reviewed
Feb 23, 2026
| try { | ||
| TrailersValidationSupport.verify(headers); | ||
| } catch (final H2ConnectionException ex) { | ||
| throw new H2StreamResetException(H2Error.PROTOCOL_ERROR, ex.getMessage()); |
Member
There was a problem hiding this comment.
@arturobernalg Please pick up my changes from master and rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC9113 8.1. HTTP Message Framing Trailers MUST NOT include pseudo-header fields (Section 8.3). An endpoint that receives pseudo-header fields in trailers MUST treat the request or response as malformed (Section 8.1.1).