Skip to content

HBASE-29874 Removing the useless parameters from ScanQueryMatcher.isC…#7720

Merged
Apache9 merged 2 commits intoapache:masterfrom
liuxiaocs7:HBASE-29874
Feb 25, 2026
Merged

HBASE-29874 Removing the useless parameters from ScanQueryMatcher.isC…#7720
Apache9 merged 2 commits intoapache:masterfrom
liuxiaocs7:HBASE-29874

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

@liuxiaocs7 liuxiaocs7 commented Feb 9, 2026

…ellTTLExpired

see: HBASE-29874

@liuxiaocs7 liuxiaocs7 force-pushed the HBASE-29874 branch 7 times, most recently from 157a9a7 to b5eebb4 Compare February 15, 2026 18:34
@liuxiaocs7
Copy link
Copy Markdown
Member Author

liuxiaocs7 commented Feb 24, 2026

Hi, @Apache9 and @junegunn, what do you think of this change, failed uts seems unrelated, thanks!

@Apache9
Copy link
Copy Markdown
Contributor

Apache9 commented Feb 24, 2026

09cd3d7

The method is added in this commit, seems the parameter is not used from beginning...

junegunn
junegunn approved these changes Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@junegunn junegunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. Safe to remove.

vaijosh
vaijosh approved these changes Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vaijosh vaijosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuxiaocs7
Copy link
Copy Markdown
Member Author

liuxiaocs7 commented Feb 24, 2026 •
edited
Loading

Failed Tests only includes Flakes error type UT(https://github.com/apache/hbase/actions/runs/22041463681?pr=7720)

image

@liuxiaocs7
Copy link
Copy Markdown
Member Author

liuxiaocs7 commented Feb 25, 2026

Hi, @Apache9 and @junegunn, thanks for the review, could you help re-trigger the failed large-wave-1 only, thanks!

@liuxiaocs7
Copy link
Copy Markdown
Member Author

liuxiaocs7 commented Feb 25, 2026

Thanks @junegunn for help re-trigger the failed CI, now it is all green!

@Apache9 Apache9 merged commit e2cfd2c into apache:master Feb 25, 2026
18 of 22 checks passed
Apache9 pushed a commit that referenced this pull request Feb 25, 2026
@liuxiaocs7 @Apache9
HBASE-29874 Removing the useless parameters from ScanQueryMatcher.isC…
e46411b 
…ellTTLExpired (#7720)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Junegunn Choi <junegunn@apache.org>
(cherry picked from commit e2cfd2c)
Apache9 pushed a commit that referenced this pull request Feb 25, 2026
@liuxiaocs7 @Apache9
HBASE-29874 Removing the useless parameters from ScanQueryMatcher.isC…
42bec52 
…ellTTLExpired (#7720)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Junegunn Choi <junegunn@apache.org>
(cherry picked from commit e2cfd2c)
Apache9 pushed a commit that referenced this pull request Feb 25, 2026
@liuxiaocs7 @Apache9
HBASE-29874 Removing the useless parameters from ScanQueryMatcher.isC…
11d4ac5 
…ellTTLExpired (#7720)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Junegunn Choi <junegunn@apache.org>
(cherry picked from commit e2cfd2c)
Apache9 pushed a commit that referenced this pull request Feb 25, 2026
@liuxiaocs7 @Apache9
HBASE-29874 Removing the useless parameters from ScanQueryMatcher.isC…
46d4aed 
…ellTTLExpired (#7720)

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Junegunn Choi <junegunn@apache.org>
(cherry picked from commit e2cfd2c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junegunn junegunn junegunn approved these changes

@Apache9 Apache9 Apache9 approved these changes

+1 more reviewer

@vaijosh vaijosh vaijosh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liuxiaocs7 @Apache9 @junegunn @vaijosh