[MINOR][VL] Add cudf build docker file with JDK 17 and cuda 12.9#11836
[MINOR][VL] Add cudf build docker file with JDK 17 and cuda 12.9#11836philo-he merged 4 commits intoapache:mainfrom
Conversation
philo-he
changed the title
philo-he
changed the title
philo-he
changed the title
philo-he
left a comment
philo-he
left a comment
There was a problem hiding this comment.
Some minor comments on names. Thank you!
There was a problem hiding this comment.
Can we name it Dockerfile.centos9-cuda12.9-cudf which is compact and seems to be more readable?
.github/workflows/docker_image.yml
Outdated
| build-args: JAVA_VERSION=17 | ||
| file: dev/docker/cudf/Dockerfile.centos9-cudf-cuda-12-9 | ||
| push: true | ||
| tags: ${{ env.DOCKERHUB_REPO }}:centos-9-jdk17-cudf-cuda-12-9 |
There was a problem hiding this comment.
Docker name suggestion: centos-9-jdk17-cuda12.9-cudf
There was a problem hiding this comment.
The docker name aligns with centos-9-jdk8-cudf, do you think I should also update the former?
There was a problem hiding this comment.
But for compatibility, I don't support to change the old name, then if the new image name should align with the former pattern? Looking for your suggestiion.
There was a problem hiding this comment.
@jinchengchenghh, maybe, we can just follow the suggested name pattern for new docker images, not changing the old ones. We don’t need to force consistency. Since the old images may become legacy, we can drop them in the future or defer a full update until we can guarantee compatibility. Just a minor suggestion. Thanks.
.github/workflows/docker_image.yml
Outdated
| push: true | ||
| tags: ${{ env.DOCKERHUB_REPO }}:centos-9-jdk8-cudf | ||
|
|
||
| build-centos-9-jdk17-cudf-cuda-12-9: |
There was a problem hiding this comment.
build-centos-9-jdk17-cuda12.9-cudf:
There was a problem hiding this comment.
The name is invalid, so I rename to build-centos-9-jdk17-cuda12_9-cudf
The identifier 'build-centos-9-jdk17-cuda12.9-cudf' is invalid. IDs may only contain alphanumeric characters, '_', and '-'. IDs must start with a letter or '_' and and must be less than 100 characters.
2 participants
Build the docker image
apache/gluten:centos-9-jdk17-cuda12.9-cudf, installed the cudf related libraries in system library path.