[VL] Fix native union use column type name as column name lead to result error#11832
Open
lifulong wants to merge 1 commit intoapache:mainfrom
Open
[VL] Fix native union use column type name as column name lead to result error#11832lifulong wants to merge 1 commit intoapache:mainfrom
lifulong wants to merge 1 commit intoapache:mainfrom
Conversation
fd8d6bd to
eeac8c7
Compare
Contributor
Author
|
the error is clear, reproduce error result need complex union sql, maybe no need add unittest, i am not sure |
c67261f to
06b7341
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fix native union result use column type name as column name, which lead to same data type column has same data, but is not right result. eg all string columns has same data value as the first string column
const auto name = outRowType->childAt(colIdx)->name();result name is column type name
const auto name = outRowType->nameOf(colIdx);result name is column name
with conf spark.gluten.sql.native.union=true and use sql like