Open
Conversation
zhouyuan
force-pushed
the
rebase_iceberg
branch
4 times, most recently
from
224b8e9 to
947dc98
Compare
|
Run Gluten Clickhouse CI on x86 |
Add ignoreNulls parameter to VeloxCollectList/VeloxCollectSet to support Spark's RESPECT NULLS syntax (SPARK-55256). When ignoreNulls=false, null elements are included in the collected array. - VeloxCollect: conditionally skip nulls based on ignoreNulls parameter - CollectRewriteRule: propagate ignoreNulls from Spark's CollectList/CollectSet via reflection (backward-compatible with Spark versions without ignoreNulls) - ArrayType containsNull reflects the ignoreNulls setting Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Yuan <yuanzhou@apache.org>
zhouyuan
force-pushed
the
rebase_iceberg
branch
from
947dc98 to
8b7c5bf
Compare
…t_set/list When aggregate functions have multiple signatures with the same intermediate type (e.g., collect_set with 1-arg and 2-arg signatures), Velox registers companion functions with suffix using generic type variables (e.g., collect_set_merge_extract_array_T). The Substrait layer was constructing concrete type suffixes (e.g., array_row_VARCHAR_BIGINT_BIGINT_endrow) that don't match. Fix: After failing exact concrete suffix lookup, fall back to discovering companion function names via getCompanionFunctionSignatures() API. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?