Skip to content

FELIX-6822 Add default to Servlet Context Name #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Positronic-Brain wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

FELIX-6822 Add default to Servlet Context Name #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...n/java/org/apache/felix/hc/core/impl/servlet/HealthCheckExecutorServletConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@
@interface HealthCheckExecutorServletConfiguration {

String SERVLET_PATH_DEFAULT = "/system/health";
String HTTP_SERVICE_CONTEXT_NAME = "org.osgi.service.http";
Copy link
Member

@kwin kwin Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to redefine this constant, just use https://docs.osgi.org/javadoc/osgi.cmpn/8.0.0/org/osgi/service/http/whiteboard/HttpWhiteboardConstants.html#HTTP_WHITEBOARD_DEFAULT_CONTEXT_NAME

Copy link
Contributor

@stbischof stbischof Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


@AttributeDefinition(name = "Servlet Context Name", description = "Servlet Context Name to register the servlet with. If not specified, the default context is used.")
String servletContextName();
@AttributeDefinition(name = "Servlet Context Name", description = "Servlet Context Name to register the servlet with. If not specified, the default context name 'org.osgi.service.http' is used.")
String servletContextName() default HTTP_SERVICE_CONTEXT_NAME;

@AttributeDefinition(name = "Servlet Path", description = "Servlet path (defaults to " + SERVLET_PATH_DEFAULT + ")")
String servletPath() default SERVLET_PATH_DEFAULT;
Expand Down