Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the Maven publish script by updating repository URLs and adding GPG plugin configuration. The changes migrate from Sonatype's s01 instance to Apache's official repository infrastructure.
Key Changes
- Added GPG plugin configuration with agent-based secure passphrase handling and commented optional settings for CI environments
- Updated Nexus repository URLs from
s01.oss.sonatype.orgtorepository.apache.orgacross all deployment locations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <!-- <gpgExecutable>gpg</gpgExecutable> --> | ||
| <!-- | ||
| <arguments> | ||
| <argument>--pinentry-mode</argument> |
There was a problem hiding this comment.
The HTML entity encoding -- is used instead of plain text -- in this XML comment. Since this is inside an XML comment block, you should use the literal double dash -- rather than HTML entities. The HTML entity encoding is unnecessary here and makes the comment harder to read.
| <argument>--pinentry-mode</argument> | |
| <argument>--pinentry-mode</argument> |
| @@ -296,7 +314,7 @@ | |||
| <extensions>true</extensions> | |||
| <configuration> | |||
| <serverId>sonatype</serverId> | |||
There was a problem hiding this comment.
The serverId and repository IDs are still named "sonatype" but the URLs have been changed to Apache's repository. This creates a naming inconsistency where the identifier suggests Sonatype but the actual repository is Apache. Consider renaming these IDs from "sonatype" to something more appropriate like "apache" or "apache-repository" to better reflect the actual repository being used.
| <id>sonatype</id> | ||
| <url>https://s01.oss.sonatype.org/content/repositories/snapshots/</url> | ||
| <url>https://repository.apache.org/content/repositories/snapshots/</url> | ||
| </snapshotRepository> | ||
| <repository> | ||
| <id>sonatype</id> |
There was a problem hiding this comment.
The repository ID "sonatype" is inconsistent with the actual repository URL which points to Apache's repository. This ID should match the serverId configured in the nexus-staging-maven-plugin (line 316) and should be renamed to better reflect that it's an Apache repository rather than Sonatype.
Fixes #issue_id
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation