Feat/3255 new config api tests by Snow-kal · Pull Request #3283 · apache/dubbo-go

Snow-kal · 2026-03-29T08:47:19Z

New Config API 集成测试的补全

测试到文件映射表

测试文件	目标	主要覆盖	直接涉及的 New Config API 文件
`inst_test.go`	验证主链路可用：`NewInstance -> NewServer/NewClient -> 实际调用成功`	实例初始化、服务注册与导出、客户端引用	`dubbo.go`、`options.go`、`server/server.go`、`server/options.go`、`server/action.go`、`client/client.go`、`client/options.go`、`client/action.go`、`protocol/options.go`、`protocol/triple/triple.go`、`protocol/triple/server.go`、`protocol/triple/client.go`、`protocol/triple/triple_invoker.go`
`prio_test.go`	验证优先级：`Instance` 默认值可被 `Client/Server` 覆盖且不互相污染	`NewServer/NewClient` 配置注入与覆盖顺序、server/service 生效值、client/reference 生效值	`dubbo.go`、`options.go`、`server/options.go`、`server/server.go`、`client/options.go`、`client/client.go`、`client/action.go`
`compat_test.go`	验证 compat 一致性：`compatRootConfig <-> compatInstanceOptions` 关键字段 round-trip 不丢失	新旧配置模型的转换、nil/空集合边界	`compat.go`、`options.go`、`global/application_config.go`、`global/protocol_config.go`、`global/client_protocol_config.go`、`global/triple_config.go`、`global/http3_config.go`、`global/registry_config.go`、`global/provider_config.go`、`global/service_config.go`、`global/consumer_config.go`、`global/reference_config.go`、`global/method_config.go`、`global/metric_config.go`、`global/otel_config.go`、`global/shutdown_config.go`、`global/custom_config.go`、`global/profiles_config.go`

为什么放根目录：测试是 package dubbo 顶层 API，且 compat 需要访问未导出函数（compatRootConfig/compatInstanceOptions）

未覆盖范围： Nacos/ZK/Apollo 外部联调，不修改 CI 流程，不改 samples

Description

issue #3255

Checklist

I confirm the target branch is develop
Code has passed local testing
I have added tests that prove my fix is effective or that my feature works

cover NewInstance -> NewServer/NewClient -> unary call path with tri direct url include required SPI imports for cluster/loadbalance and deterministic cleanup

replace broad SPI imports with minimal required ones set server filter to echo and client cluster to available to reduce registration requirements

cover server and client precedence between instance defaults and per-layer overrides verify overrides do not pollute later NewServer/NewClient creations

add compat round-trip and nil-handling tests for key config sections align inst/prio test files with concise English comments following repo style

rename inst/prio/compat test files to integration naming keep test behavior unchanged and update integration instance name

replace Len(..., 0) with Empty(...) in compat integration test

Copilot

Pull request overview

This PR adds root-level integration tests to validate the new Config API’s core behavior: end-to-end instance/server/client wiring, option precedence (Instance defaults vs Server/Client overrides), and compat round-trip conversions between the new and legacy config models.

Changes:

Add an end-to-end unary invocation integration test using NewInstance -> NewServer/NewClient -> CallUnary.
Add priority/override integration tests to ensure Server/Client options override Instance defaults without leaking across subsequent creations.
Add compat conversion round-trip tests, including nil/empty-collection edge cases.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
inst_integration_test.go	End-to-end new Config API integration test with real Triple unary invocation.
prio_integration_test.go	Tests precedence/isolation of Instance vs Server/Client overrides for group/version.
compat_integration_test.go	Tests compat conversion round-trip and nil/empty handling for key config sections.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

server/inst_test.go

codecov-commenter · 2026-03-29T08:55:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.08%. Comparing base (fb8eff2) to head (f0062a2).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3283      +/-   ##
===========================================
+ Coverage    48.96%   50.08%   +1.12%     
===========================================
  Files          467      469       +2     
  Lines        34006    34601     +595     
===========================================
+ Hits         16652    17331     +679     
+ Misses       16019    15869     -150     
- Partials      1335     1401      +66

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

use context.WithTimeout per retry to prevent hanging CallUnary from wedging CI

Alanxtl · 2026-03-29T13:56:13Z

这几个文件放到根目录下也太丑陋了
为什么文件名称是集成测试（integration_test）它和集成测试有什么关系吗

…on suffix

sonarqubecloud · 2026-04-05T11:57:25Z

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Snow-kal · 2026-04-05T12:00:40Z

感谢建议
目前是按职责把测试放到 server/client/config 子目录

dubbo-go/server/inst_test.go
dubbo-go/client/prio_test.go
dubbo-go/config/compat_test.go

然后那个文件命名我想请问一下是多加了 integration 这个的原因吗因为我是看项目里也有类似的命名比如 triple_case_route_integration_test.go 这样照着写的

Alanxtl · 2026-04-05T13:47:26Z

感谢建议目前是按职责把测试放到 server/client/config 子目录

dubbo-go/server/inst_test.go dubbo-go/client/prio_test.go dubbo-go/config/compat_test.go

然后那个文件命名我想请问一下是多加了 integration 这个的原因吗因为我是看项目里也有类似的命名比如 triple_case_route_integration_test.go 这样照着写的

是的 integration test 是集成测试的意思，但是你加的这些都是单元测试呀

Alanxtl

lgtm

AlexStocks

Code review for new config API tests

AlexStocks · 2026-04-06T11:54:58Z

client/prio_test.go

+	"github.com/stretchr/testify/require"
+)
+
+import (


[P1] 规范级问题：常量命名可以适当缩短以提高可读性，如 newConfigAPIPriorityInstanceGroup 可改为 prioTestInstanceGroup。过长的标识符降低了代码的可读性。

AlexStocks · 2026-04-06T11:54:58Z

config/compat_test.go

+// TestNewConfigAPI_CompatRoundTripPreservesKeyFields verifies that the
+// compatibility bridge keeps key fields consistent in root config.
+func TestNewConfigAPI_CompatRoundTripPreservesKeyFields(t *testing.T) {
+	_, err := dubbo.NewInstance(buildNewConfigAPICompatFixture())


[P1] 规范级问题：TestNewConfigAPI_CompatRoundTripPreservesKeyFields 函数过长，建议拆分为多个更小的测试函数，每个测试特定配置部分（应用配置、协议配置等），便于维护和定位问题。

AlexStocks · 2026-04-06T11:54:58Z

server/inst_test.go

+			},
+		},
+	}
+


[P0] 阻断级问题：虽然添加了 context.WithTimeout 防止挂起，但错误处理仍可能掩盖底层问题。建议在重试循环中添加更详细的错误日志记录，以便在调试时更容易发现问题根源。

AlexStocks · 2026-04-06T11:54:58Z

server/inst_test.go

+	require.NoError(t, callErr)
+	assert.Equal(t, newConfigAPIHelloBody, resp.Value)
+}
+


[P1] 规范级问题：导入顺序不完全符合 Go 语言规范，建议按照标准库、第三方库、项目内模块的顺序整理导入语句。

AlexStocks

Additional code review comments

AlexStocks · 2026-04-06T11:55:08Z

server/inst_test.go

+	"dubbo.apache.org/dubbo-go/v3/protocol"
+	_ "dubbo.apache.org/dubbo-go/v3/protocol/triple"
+	tri "dubbo.apache.org/dubbo-go/v3/protocol/triple/triple_protocol"
+	_ "dubbo.apache.org/dubbo-go/v3/proxy/proxy_factory"


[P1] 规范级问题：测试函数 TestNewConfigAPI_InstanceNewServerNewClientCallUnary 集成了太多步骤，建议将其分解为更小的单元测试。当前的测试涵盖了实例创建、服务注册、客户端连接和调用等多个步骤，不利于故障隔离。

AlexStocks · 2026-04-06T11:55:08Z

config/compat_test.go

+		opts.Protocols = map[string]*global.ProtocolConfig{
+			newConfigAPICompatProtocolID: {
+				Name:                 "tri",
+				Ip:                   "127.0.0.1",


[P2] 建议级问题：buildNewConfigAPICompatFixture 函数构建了大量配置项，可考虑使用测试构建器模式或工厂函数简化测试配置的创建，提高可维护性。

AlexStocks · 2026-04-06T11:55:08Z

client/prio_test.go

+	newConfigAPIPriorityServiceMethod   = "Ping"
+)
+
+type newConfigAPIReferenceSnapshot struct {


[P2] 建议级问题：registerNewConfigAPIPriorityService 函数中使用了 require.NotZero 和 require.NotNil，可以考虑添加更多的断言来验证服务选项的其他属性，以增强测试的完整性。

Snow-kal added 5 commits March 29, 2026 15:57

test(new-config-api): add instance integration smoke test

158fbe8

cover NewInstance -> NewServer/NewClient -> unary call path with tri direct url include required SPI imports for cluster/loadbalance and deterministic cleanup

test(new-config-api): trim instance itest dependencies

37b2d19

replace broad SPI imports with minimal required ones set server filter to echo and client cluster to available to reduce registration requirements

test(new-config-api): add priority integration tests

7161397

cover server and client precedence between instance defaults and per-layer overrides verify overrides do not pollute later NewServer/NewClient creations

test(new-config-api): add compat integration tests

cb316e0

add compat round-trip and nil-handling tests for key config sections align inst/prio test files with concise English comments following repo style

test(new-config-api): rename itest files to integration

d322120

rename inst/prio/compat test files to integration naming keep test behavior unchanged and update integration instance name

Copilot AI review requested due to automatic review settings March 29, 2026 08:47

Copilot started reviewing on behalf of Snow-kal March 29, 2026 08:47 View session

test(new-config-api): satisfy testifylint empty assertions

eb23a06

replace Len(..., 0) with Empty(...) in compat integration test

Copilot AI reviewed Mar 29, 2026

View reviewed changes

server/inst_test.go Show resolved Hide resolved

test(new-config-api): bound unary retries by attempt timeout

1c92160

use context.WithTimeout per retry to prevent hanging CallUnary from wedging CI

Alanxtl added 🧹 Updates 3.3.2 version 3.3.2 labels Mar 29, 2026

Alanxtl linked an issue Mar 29, 2026 that may be closed by this pull request

[Proposal] Integration test new Config API #3255

Open

1 task

test(new-config-api): move tests to module packages without integrati…

f0062a2

…on suffix

Alanxtl approved these changes Apr 5, 2026

View reviewed changes

AlexStocks reviewed Apr 6, 2026

View reviewed changes

Conversation

Snow-kal commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Config API 集成测试的补全

测试到文件映射表

Description

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

codecov-commenter commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Alanxtl commented Mar 29, 2026

Uh oh!

sonarqubecloud bot commented Apr 5, 2026

Quality Gate passed

Uh oh!

Snow-kal commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alanxtl commented Apr 5, 2026

Uh oh!

Alanxtl left a comment

Choose a reason for hiding this comment

Uh oh!

AlexStocks left a comment

Choose a reason for hiding this comment

Uh oh!

AlexStocks Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

AlexStocks Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

AlexStocks Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

AlexStocks Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

AlexStocks left a comment

Choose a reason for hiding this comment

Uh oh!

AlexStocks Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

AlexStocks Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

AlexStocks Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Snow-kal commented Mar 29, 2026 •

edited

Loading

codecov-commenter commented Mar 29, 2026 •

edited

Loading

Snow-kal commented Apr 5, 2026 •

edited

Loading